Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH key simplify #56

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SSH key simplify #56

wants to merge 2 commits into from

Conversation

julesvanrie
Copy link
Contributor

@julesvanrie julesvanrie commented Feb 8, 2025

Fixes https://github.com/lewagon/teachers/issues/3069

Note:

  • The instructions for using the ssh connection in VS Code for Windows are not updated yet. The instructions on that part are currently only valid for MacOS. I haven't figured out a sufficiently easy similar thing for Windows yet.
  • That said: that should not withhold us from bringing in the other changes which are a definite improvement for all, even if this last thing is not yet solved.

@julesvanrie julesvanrie requested a review from lorcanrae February 8, 2025 17:14
@lorcanrae
Copy link
Contributor

Yeah I see the issue, the SSH VSCode setup is indeed very unix-like heavy. It probably deserves separate expanded instructions for Windows - drop downs based on OS or additional bullet points for clarity.

Agree that we should just use a key named de-bootcamp for the bootcamp. It's relatively common that students already have an existing id_ed25519 key.

I'll add an mkdir -p ~/.ssh to create the folder on unix-likes for students that don't have it. I might play around in my windows partition to find the powershell equivalent.

@julesvanrie
Copy link
Contributor Author

I'll add an mkdir -p ~/.ssh to create the folder on unix-likes for students that don't have it. I might play around in my windows partition to find the powershell equivalent.

Don't have my Windows laptop at hand now, but in PowerShell it's probably as easy as putting in backslashes instead of slashes. I think they made it as a convenience function. Not sure about the -p option. So mkdir ~\.ssh should suffice: ~ exists anyway, and if the folder already exists that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants