Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request renames and generalizes the Rust-based WASM samples to "WASM-JS" samples, reflecting a shift to a JS-first approach where JavaScript code is run via a Rust-based Boa JS runner compiled to WASM. The changes update documentation, Makefile logic, and sample directory structure to use
wasm-jsinstead ofwasm-rust, clarify build output locations, and ensure compatibility with previous variable names for smooth transition.The most important changes are:
Build System and Output Structure:
wasm-jsandBUILD_JS_SAMPLES/JS_SAMPLESvariables instead ofwasm-rustandBUILD_RUST_SAMPLES/RUST_SAMPLES, with compatibility handling for old variable names. Build outputs are now placed insamples/build/js/(with a compatibility copy insamples/build/rust/). [1] [2]Documentation and Sample Directory Updates:
wasm-rusttowasm-js, describing the new JS-first approach using a Boa JS runner, and clarifying that the main output directory is nowbuild/js/. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]New Sample Directory:
samples/wasm-js/README.mdis added to explain the JS-first sample approach, where JavaScript code is executed via the WASM-compiled Boa JS runner.Minor Code Change:
samples/wasm-c/chat_completion.cis enabled, though this is unrelated to the main theme of the PR.