default md5.h to define function prototypes#710
Merged
jameskermode merged 1 commit intopublicfrom Jan 29, 2026
Merged
Conversation
This was referenced Jan 29, 2026
Closed
akohlmey
reviewed
Jan 29, 2026
src/libAtoms/md5.h
Outdated
| returns an empty list. | ||
| */ | ||
| #if PROTOTYPES | ||
| #ifndef NO_PROTOTYPES |
There was a problem hiding this comment.
I would not make this change here, but rather change the default in line 10 to #define PROTOTYPES 1. That integrates cleaner and does not require changes in the names of defines.
bernstei
force-pushed
the
md5_prototypes
branch
from
a7f248f to
c73d073
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modernize
md5.[ch]Axel Kohlmeyer is not wrong that defaulting to no function prototypes is very outdated