Refactor orientation-determining code

[nmnobre]

Hi,

Though this keeps lexicographic ordering on the point coordinates as the orientation-determining factor, there is now both a single place where we determine edge orientations, Elem::positive_edge_orientation(), and a single place where we determine face orientations, Elem::positive_face_orientation(), for the entire codebase. This should make things easier if and when we decide to switch to comparing ids instead.

Cheers,
Nuno

[moosebuild]

Job Coverage, step Generate coverage on f927733 wanted to post the following:

Coverage

	1fba56	#4124 f92773
	Total	Total	+/-	New
Rate	63.32%	63.32%	+0.00%	65.07%
Hits	74333	74328	-5	95
Misses	43056	43053	-3	51

Diff coverage report

Full coverage report

Warnings

• New new line coverage rate 65.07% is less than the suggested 90.0%

This comment will be updated on new commits.

[nmnobre]

I'd love to take credit for something clever but this code doesn't look familiar at all ;-)

Oh, I think you might be right @jwpeterson, the furthest I can go is to a massive commit by David Knezevic in 2011. The code I based the new face orientation function on seems to be from "the before times".