More exhaustive boundary sync tests, fixes #4180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are good defaults for a default constructor, but if the source mesh overrode them then we need to too. This fixes clone() self-consistency and assertion failures in some cases.
We weren't properly covering the Replicated->Distributed case or the Distributed->Replicated case, just Replicated->Replicated and Distributed->Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@YaqiWang hit a couple bugs in BoundaryInfo::sync() combinations that I anticipated well enough to support but apparently didn't anticipate well enough to properly test. This PR adds bug fixes, better test coverage, and bug fixes for bugs revealed when they were triggered by the first bug fixes. This was all reordered via rebase so the intermediate commits here shouldn't be any more broken than their predecessors.