Skip to content

Start preparing some automation helpers, update building docs a bit #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tylert
Copy link

@tylert tylert commented Mar 27, 2025

The Dockerfile is intended to try to give folks another option for their local build environment. There is a chance this work will also aid in future attempts to get GitHub actions going for automating release building too.

The nrf52_post_prep.py helper Python script is intended to be called from the Makefile make prep-nrf target. However, I would appreciate some help testing this on non-Linux targets first before I call this on every build. It is needed because there isn't yet a new release of the Heltec_nRF52 dev env (HelTecAutomation/Heltec_nRF52#4).

@tylert tylert force-pushed the some-doc-updates branch 2 times, most recently from 775a127 to 449ef09 Compare March 30, 2025 16:47
@jacobeva
Copy link

jacobeva commented Apr 6, 2025

Nice PR. Some notes:
Please create a scripts (capital S) folder and put the python script into it. This is just to keep things tidy.
The script should really be renamed. It's only needed when compiling for the T114 at the moment. heltec_nrf52_bsp_prep.py will do as the filename if you can't think of anything shorter. It needs to be clear what it's for else some may misunderstand.

Once this is done, I'm happy to merge. Thanks for the work Tyler.

@tylert tylert force-pushed the some-doc-updates branch from 449ef09 to 1b31da1 Compare April 6, 2025 20:51
@tylert
Copy link
Author

tylert commented Apr 6, 2025

Done.

We'll also have to wait for another pending change to the Dockerfile after there's a release to fix arduino/arduino-cli#2860 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants