Skip to content

update gossip #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

update gossip #300

wants to merge 12 commits into from

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Mar 17, 2025

  • update gossipsub #297
  • compare with rust-libp2p (old floodsub) (gossipsub)
  • test gossip peer against mock streams/peers
  • respect peer protocol version
  • (rust) separate MessageCache (id and message data, gossip ihave, reply to iwant) and DuplicateCache (id only)
  • (rust) gossip in heartbeat instead of publish/forward, may gossip same message to more peers in more heartbeats
  • fanout peers (publish when we are not subscribed, like mesh but without explicit graft)
  • send prune with backoff
  • flood publishing (not same as floodsub)
  • idontwant
  • score
  • opportunistic graft
  • maintain outbound peer count in mesh
  • fix Connectivity/Stream/GossipCore shared_ptr cycle/leak.
  • remove hasTopic, add isSubscribed
  • remove empty, add isUsed
  • simplify stream write batch
  • fix MessageReadWriterUvarint returned null for zero size message
  • stubs: ExplicitPeers

Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested a review from kamilsa March 19, 2025 02:58
@turuslan turuslan changed the title update gossip (part 1) update gossip Mar 28, 2025
Signed-off-by: turuslan <[email protected]>
@kamilsa kamilsa requested a review from Copilot April 7, 2025 13:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 35 out of 38 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • cmake/Hunter/config.cmake: Language not supported
  • cmake/Hunter/init.cmake: Language not supported
  • src/connection/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)

src/basic/message_read_writer_uvarint.cpp:47

  • In the case where msg_len equals 0, 'buffer' is used without being declared. Consider returning an empty shared pointer (or an appropriate default value) instead of 'buffer' to prevent compilation/runtime issues.
cb(buffer);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant