Skip to content

Conversation

@parth-soni07
Copy link
Contributor

What was wrong?

The codebase previously relied on a custom async_service implementation, which was no longer actively maintained and introduced unnecessary complexity. It made lifecycle management fragile and lacked support for modern async patterns and structured concurrency.

Issue #524

How was it fixed?

The legacy async_service implementation was fully replaced with a new design built using anyio, a well-supported, high-level async framework. This transition modernizes the service infrastructure and significantly improves reliability, maintainability, and task supervision.

@seetadev
Copy link
Contributor

@parth-soni07 : Thank you so much for sharing this PR. Appreciate your great efforts and contribution. We will jointly do a detailed review. Will share feedback soon.

Wish if you could resolve the merge conflicts. Once resolved, please ping me.

I will re-run the CI/CD pipeline and share test results soon.

Also, CCing @acul71, @sumanjeet0012 and @pacrob.

@sumanjeet0012
Copy link
Contributor

@parth-soni07 I have reviewed the PR and have a few observations:
1. The PR title indicates that we are creating an async service using AnyIO, but the implementation uses Trio instead.
2. The test directory is still named async_service instead of anyio_service.
3. The newsfragment file appears to be missing.

@parth-soni07
Copy link
Contributor Author

@parth-soni07 I have reviewed the PR and have a few observations: 1. The PR title indicates that we are creating an async service using AnyIO, but the implementation uses Trio instead. 2. The test directory is still named async_service instead of anyio_service. 3. The newsfragment file appears to be missing.

Hey @sumanjeet0012 , thank you for your insights, yes indeed this is supposed to be a anyio migration and not trio, I have made some changes in the implementation to align with the name of the PR and use anyio. I am facing some issues in the version of anyio that is used in the p2pclient so currently working on that, will definitely ping once I am done with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants