Skip to content
This repository has been archived by the owner on Mar 14, 2018. It is now read-only.

Minor change, device list look #201

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Rosiak
Copy link
Member

@Rosiak Rosiak commented Jun 5, 2017

Might seem a little bit hackey, but hey it's progress.
ss2
ss1

@@ -24,7 +24,7 @@
'address' => 'Address',
'mac_address' => 'MAC Address',
'port_descr' => 'Description',
'status' => 'Status',
'status' => '',
'unauthorized' => 'Unauthorized',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit the translation :)

@@ -71,7 +71,6 @@ public function getColumns()
'status' => [
'title' => trans('general.text.status'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit the title here

display: block;
font-size: medium;
margin: 0 3px;
margin: 0 0 0 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer margin: 0;

@if($disabled == 1)
<div class="device-status" title="Disabled" style="background:grey;"></div>
@elseif($ignore == 1)
<div class="device-status" title="Ignored" style="background:yellow;"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think yellow is the right color here, but I'm fine with it.

@Rosiak
Copy link
Member Author

Rosiak commented Jun 6, 2017

Thx @murrant

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants