Skip to content

Add support for min/max query in libretrodb #18314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for min/max query in libretrodb #18314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions libretro-db/query.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ struct registered_func
rarch_query_func func;
};

struct rmsgpack_dom_value intermediate_res;

/* Forward declarations */
static struct buffer query_parse_method_call(char *s, size_t len,
struct buffer buff, struct invocation *invocation, const char **err);
Expand Down Expand Up @@ -254,12 +256,85 @@ static struct rmsgpack_dom_value query_func_glob(
return res;
}

/* Min and max functions will return all entries smaller/larger than previous *
* - in practice, last entry will contain the actual min/max value. *
* Empty result means there is no such field. */
static struct rmsgpack_dom_value query_func_min(
struct rmsgpack_dom_value input,
unsigned argc, const struct argument * argv)
{
struct rmsgpack_dom_value res;

res.type = RDT_BOOL;
res.val.bool_ = 0;

switch (input.type)
{
case RDT_INT:
res.val.bool_ = (
(input.val.int_ == 0)
|| (input.val.int_ < intermediate_res.val.int_)
|| (intermediate_res.val.int_ == 0));
if (res.val.bool_ || intermediate_res.val.int_ == 0)
memcpy(&intermediate_res, &input, sizeof(intermediate_res));
break;
case RDT_UINT:
res.val.bool_ = (
(input.val.uint_ == 0)
|| (input.val.uint_ < intermediate_res.val.uint_)
|| (intermediate_res.val.uint_ == 0));
if (res.val.bool_ || intermediate_res.val.uint_ == 0)
memcpy(&intermediate_res, &input, sizeof(intermediate_res));
break;
default:
break;
}

return res;
}

static struct rmsgpack_dom_value query_func_max(
struct rmsgpack_dom_value input,
unsigned argc, const struct argument * argv)
{
struct rmsgpack_dom_value res;

res.type = RDT_BOOL;
res.val.bool_ = 0;

switch (input.type)
{
case RDT_INT:
res.val.bool_ = (
(input.val.int_ == 0)
|| (input.val.int_ > intermediate_res.val.int_)
|| (intermediate_res.val.int_ == 0));
if (res.val.bool_ || intermediate_res.val.int_ == 0)
memcpy(&intermediate_res, &input, sizeof(intermediate_res));
break;
case RDT_UINT:
res.val.bool_ = (
(input.val.uint_ == 0)
|| (input.val.uint_ > intermediate_res.val.uint_)
|| (intermediate_res.val.uint_ == 0));
if (res.val.bool_ || intermediate_res.val.uint_ == 0)
memcpy(&intermediate_res, &input, sizeof(intermediate_res));
break;
default:
break;
}

return res;
}

struct registered_func registered_functions[100] = {
{"is_true", query_func_is_true},
{"or", query_func_operator_or},
{"and", query_func_operator_and},
{"between", query_func_between},
{"glob", query_func_glob},
{"min", query_func_min},
{"max", query_func_max},
{NULL, NULL}
};

Expand Down Expand Up @@ -905,6 +980,9 @@ void *libretrodb_query_compile(libretrodb_t *db,
struct query *q = (struct query*)malloc(sizeof(*q));
size_t err_buff_len = sizeof(tmp_err_buff);

intermediate_res.val.int_ = 0;
intermediate_res.val.uint_ = 0;

if (!q)
return NULL;

Expand Down
Loading