Fix 3DS scan #18410
Merged
Fix 3DS scan #18410
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several rom sizes could exceed 32-bit. Database uses uint64_t, so let's align.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rom size was truncated to 32-bit. In case of 3DS database, the maximum size is exactly 0x100000000, so the maximum size came up as 0, as shown on extra debug logs (visible in debug builds):
[DEBUG] [Scanner] Queried min/max, values 39018496 / 0, size yes serial yes crc yesSize field is updated to 64-bit to align with RDS contents.
[DEBUG] [Scanner] Queried min/max, values 39018496 / 4294967296, size yes serial yes crc yesRelated Issues
#18341 (comment)
Related Pull Requests
#18341