-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Adding SDL_HINT_IME_PAN_PADDING "SDL_IME_PAN_PADDING". #15048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DominusExult
wants to merge
3
commits into
libsdl-org:main
Choose a base branch
from
DominusExult:sdl_hint_ime_pan_padding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−5
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous padding value was 0, so we need to subtract 15, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wrong about the automatic padding on iOS, so
0inint panPadding = (hint && *hint) ? SDL_atoi(hint) : 0;was actually setting it to no padding by default and now15is adding the new default.I have no idea why I saw a padding and now don't see it with padding set to 0. Probably too many windows open with too many branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it look consistent with the Android version with 15 points of padding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the division it looks consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so what you want to do is set the hint in testime, and use the same conversion to window coordinates calculation on the hint value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slouken is this correct now? I'm really struggling with window coordinates, points and pixels, but window coordinates equals points, so no conversion for iOS. And is the conversion to pixels correct (window coordinates * density)?
It looks almost equal with different paddings while on Android the padding looks just a tiny bit more. Probably would need visual help in TestIME to really tell :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Points == pixels on Android, so no conversion is needed there either. Basically, no conversion is necessary in SDL code for either platform. You're so close! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But... I don't understand this then.
If I don't apply any conversion, the padding on either platform is visibly far from the same.
Applying the Android conversion makes it close but not quite the same (the higher the padding the more it drifts apart). I'm really at a loss at how to do this properly.
TestIME padding of 50, and as a visual guide I've added the setting_icon a couple of times (input at 250.0f, both show 5 + something setting icons underneath without the IME).

No conversion iOS (and incidentally my conversion attempt shows the same):
No conversion Android:

Conversion Android:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll go ahead and merge this and clean it up afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looking forward to see/learn what is the right way.