Open
Conversation
|
hello, |
|
@panghaichao You need modify the Dockerfile. When build docker image, it's clone from github now, should copy files from local repo. |
|
Can we merge this PR? This would be super-helpful. The Docker image will be built automatically, IIUC. Maybe the image size also gets reduced by this, automagically, as suggested in #691. |
|
NOTE: That would be sufficient: def read_file(filename):
with open(filename) as thefile:
return thefile.read()
requires = read_file('requirements.txt') |
|
This PR, in addition to pinning the Dockerfile image is required to make building this repo work. Until this repo starts getting maintained again, I've setup a Docker hub autobuild with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the Docker image was also affected by #689, so I set about fixing :)