Skip to content

fix: WebPlatformChrome50 createImageBitmap not works on the ImageWorker#757

Merged
wouterlucas merged 7 commits intolightning-js:mainfrom
pecoram:fix/platformChrome50
Mar 20, 2026
Merged

fix: WebPlatformChrome50 createImageBitmap not works on the ImageWorker#757
wouterlucas merged 7 commits intolightning-js:mainfrom
pecoram:fix/platformChrome50

Conversation

@pecoram
Copy link
Contributor

@pecoram pecoram commented Mar 11, 2026

No description provided.

@pecoram pecoram requested a review from wouterlucas March 13, 2026 11:06
@wouterlucas
Copy link
Contributor

this still has all the ImageWorkers imported, creating unneededly larger bundles -> slower image worker loading times.

IMHO:

  • Drop ImageWorkerManager no need for it
  • Directly import ImageWorkerX based on the platform you have, so legacy imports the legacy one, chrome 50 the no options, etc.

That way no overhead, neatly separated bundles and no additional code that can break other then what is strictly needed for the platform.

@pecoram pecoram closed this Mar 19, 2026
@pecoram pecoram reopened this Mar 19, 2026
@wouterlucas wouterlucas merged commit 13c3533 into lightning-js:main Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants