Various C# build fixes #147
Merged
+54
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generally expect to allocate pointers in C which Rust will free,
and vice versa. On Windows, this requires that we use the same
allocation path as Rust's stdlib does, which is actually
`Heap{Alloc,Free}`, not `malloc`/`free`. Here, we swap the heap
allocation functions we call, fixing heap corruption issues on
Windows.
webwarrior-ws
pushed a commit
to webwarrior-ws/ldk-garbagecollected
that referenced
this pull request
Mar 7, 2024
Original commit: lightningdevkit@e38583b from lightningdevkit#147
webwarrior-ws
pushed a commit
to webwarrior-ws/ldk-garbagecollected
that referenced
this pull request
Mar 7, 2024
webwarrior-ws
pushed a commit
to webwarrior-ws/ldk-garbagecollected
that referenced
this pull request
Mar 7, 2024
Original commit: lightningdevkit@2c4caca from lightningdevkit#147
webwarrior-ws
pushed a commit
to webwarrior-ws/ldk-garbagecollected
that referenced
this pull request
Mar 7, 2024
|
C# is as deterministic as ever (only a few bytes of metadata wrong) - https://github.com/TheBlueMatt/ldk-garbagecollected/actions/runs/8173797745/job/22347046036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.