Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MigratableKVStore for VssStore #469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement MigratableKVStore for VssStore #469

wants to merge 1 commit into from

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Feb 12, 2025

  • Implement MigratableKVStore for VssStore

@G8XSU G8XSU requested a review from tnull February 12, 2025 19:48
enigbe
enigbe reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@enigbe enigbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@G8XSU I have reviewed the implementation done here and it LGTM. I did some local testing to migrate from VssStore to FilesystemStore (also impl MigratableKVStore) and it works as it should.

Unrelated to this PR, but I noticed that the unit tests in src/io/vss_store require vss-server to be running at TEST_VSS_BASE_URL. Should we mock vss-server responses to keep them as unit tests, or should we move them to integration tests instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enigbe enigbe enigbe left review comments

@tnull tnull Awaiting requested review from tnull

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G8XSU @enigbe