Add counterparty_skimmed_fee_msat field to PaymentKind::Bolt11Jit
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. we add a field describing exactly how much the LSP withheld.
tnull
force-pushed
the
2025-03-payment-details-nits
branch
from
ffad4f3 to
05c77da
Compare
G8XSU
reviewed
Mar 20, 2025
| PaymentKind::Bolt11Jit { ref mut counterparty_skimmed_fee_msat, .. } => { | ||
| update_if_necessary!(*counterparty_skimmed_fee_msat, skimmed_fee_msat); | ||
| }, | ||
| _ => {}, |
There was a problem hiding this comment.
instead of silently ignoring the payment_update here, should we add a debug_assert?
| assert_eq!(hash, h); | ||
| assert_eq!(preimage, p); | ||
| assert_eq!(secret, s); | ||
| assert_eq!(None, c); |
There was a problem hiding this comment.
nit: should we test with Some() as well?
| @@ -346,6 +364,12 @@ pub enum PaymentKind { | |||
| preimage: Option<PaymentPreimage>, | |||
| /// The secret used by the payment. | |||
| secret: Option<PaymentSecret>, | |||
| /// The value, in thousands of a satoshi, that was deducted off of this payment as an extra | |||
There was a problem hiding this comment.
"The value, in thousands of a satoshi" is an awkward way of saying that the value is in msat?
where msat is thousandth of a satoshi.
Suggested change
| /// The value, in thousands of a satoshi, that was deducted off of this payment as an extra | |
| /// The value, in millisatoshis (msat), that was deducted off of this payment as an extra |
G8XSU
reviewed
Mar 20, 2025
| @@ -41,6 +41,8 @@ pub struct PaymentDetails { | |||
| /// The kind of the payment. | |||
| pub kind: PaymentKind, | |||
| /// The amount transferred. | |||
| /// | |||
| /// Will be `None` for variable-amount payments until we received them. | |||
There was a problem hiding this comment.
Suggested change
| /// Will be `None` for variable-amount payments until we received them. | |
| /// Will be `None` for variable-amount payments until we receive them. |
G8XSU
reviewed
Mar 20, 2025
| @@ -346,6 +364,12 @@ pub enum PaymentKind { | |||
| preimage: Option<PaymentPreimage>, | |||
| /// The secret used by the payment. | |||
| secret: Option<PaymentSecret>, | |||
| /// The value, in thousands of a satoshi, that was deducted off of this payment as an extra | |||
There was a problem hiding this comment.
Suggested change
| /// The value, in thousands of a satoshi, that was deducted off of this payment as an extra | |
| /// The extra fee, in millisatoshis (msat), deducted from this payment by our channel counterparty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #495
We add a field to
Bolt11Jitdescribing exactly how much the LSP withheld.Additionally, we clarify when
PaymentDetails::amount_msatmight beNone(for now).