Client trusts lsp #572
Client trusts lsp #572
Conversation
|
🎉 This PR is now ready for review! |
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
src/event.rs
Outdated
| "Failed to process funding transaction: {:?}", | ||
| err | ||
| self.liquidity_source.as_ref().map(|ls| { | ||
| ls.lsps2_store_funding_transaction( |
There was a problem hiding this comment.
Would we always need to store the funding transaction, even if we're not doing the full flow?
There was a problem hiding this comment.
I moved it to inside the if statement, so it will store it only if needs_manual_broadcast is true 👍
src/event.rs
Outdated
| return Err(ReplayEvent()); | ||
| }, | ||
| }; | ||
| self.payment_store.update(&update).map_err(|e| { |
There was a problem hiding this comment.
There are a lot of unrelated changes happening in this commit. a) not sure if I agree that they are worth doing at all but b) always try to keep such changes in separate commits please.
There was a problem hiding this comment.
Sorry about that, I made a rebase and a cleanup. now this commit 53a8174 will have the minimal changes to make the client_trusts_lsp flow work
There was a problem hiding this comment.
There are a lot of unrelated changes happening in this commit.
This was a refactor on the PaymentClaimable event to make the manual claim work on my tests.
That part is removed after the rebase, so we should be good now
martinsaposnic
force-pushed
the
client-trusts-lsp
branch
from
480a3ce to
53a8174
Compare
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tnull! This PR has been waiting for your review. |
Please just review the second commit 53a8174. The first commit is just compatibility changes so it works with rust-lightning
This PR uses the functionality introduced in this other PR lightningdevkit/rust-lightning#3838, and creates 2 tests that demonstrates the feature
Changes: