Add Telemetry #63
Open
Add Telemetry #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ldk-server/Cargo.toml # ldk-server/src/main.rs # ldk-server/src/service.rs
G8XSU
reviewed
Mar 21, 2025
|
|
||
| use metrics_exporter_prometheus::{PrometheusBuilder, PrometheusHandle}; | ||
|
|
||
| pub fn setup_prometheus() -> PrometheusHandle { |
There was a problem hiding this comment.
please remove all the metric publishing.
https://discord.com/channels/915026692102316113/1352007400906952725/1352012213896089610
There was a problem hiding this comment.
Do you mean all their descriptions, right? Just leaving the returning handle?
# Conflicts: # Cargo.lock # ldk-server/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solve #38 by adding the
metricsandmetrics-exporter-prometheuscrates to theldk-server.By using them we start introducing telemetry to its node and services.