Optimize some ChannelMonitor stuff after #163 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hopping a pointer, we're only ever going to return one Transaction at max, so skip the Vec. Also avoid re-pubkey-converting the revocation key.
This lets us simplify a few tidbits of loop.
This effecitlvey reverts the refactors in 383bd90, however keeps the actully new test code. It also writes documentation for the super confusing tx test func and makes it a bit less permissive.
TheBlueMatt
force-pushed
the
2018-09-163-cleanups
branch
from
b562842 to
66d5d76
Compare
|
utACK, but for lacking tests as described in #137 (comment), I still put them in channel_monitor_network_test ? |
|
Doesn't matter too much, some of our tests are already a bit slow, especially on platforms that are more sensitive to non-optimized binaries, so may make sense to split it up and create a new test function for additional tests if they add too much runtime (cause they get run in paralell). I just split up test_txn_broadcast cause the new additions didn't really have anything to do with the other stuff there (which was all about spending a commitment tx). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things are cleanups of #163, and a few further optimizations I found during review. The tests were super confusing as they were so I went back and wrote documentation for the old stuff, which convinced me the new tests didn't really fit in the function they were in as they dont depend on a commitment transaction so are probably better suited to their own function.