Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async payments message encoding and prefactor #3125

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Async payments message encoding and prefactor #3125

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
66df329
ser_macros: support messages with no fields
valentinewallace Jun 5, 2024
445ec8d
Onion message payload for async payments
valentinewallace Jun 5, 2024
e8f154d
AsyncPaymentsMessageHandler trait for OnionMessenger
valentinewallace Jun 5, 2024
691e10f
DRY responder instantiation for onion messages.
valentinewallace Jun 6, 2024
6553d15
Add OffersMessage variant for static invoices.
valentinewallace May 29, 2024
f20bd3d
Remove unused imports in static_invoice.rs
valentinewallace Jun 13, 2024
5c7af8c
Cfg-gate async payments module and public enum variants.
valentinewallace Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lightning/src/util/ser_macros.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ macro_rules! impl_writeable_msg {
$($crate::_init_tlv_field_var!($tlvfield, $fieldty);)*
$crate::decode_tlv_stream!(r, {$(($type, $tlvfield, $fieldty)),*});
Ok(Self {
$($field),*,
$($field,)*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this commit is no longer required but it still seemed like a nice fix.

$($tlvfield),*
})
}
Expand Down Expand Up @@ -1531,4 +1531,18 @@ mod tests {
fn simple_test_tlv_write() {
do_simple_test_tlv_write().unwrap();
}

#[derive(Debug, Eq, PartialEq)]
struct EmptyMsg {}
impl_writeable_msg!(EmptyMsg, {}, {});

#[test]
fn impl_writeable_msg_empty() {
let msg = EmptyMsg {};
let mut encoded_msg = msg.encode();
assert!(encoded_msg.is_empty());
let mut encoded_msg_stream = Cursor::new(&mut encoded_msg);
let decoded_msg: EmptyMsg = Readable::read(&mut encoded_msg_stream).unwrap();
assert_eq!(msg, decoded_msg);
}
}