Bump electrum_client dependency and add new TLS-backend features
#3587
+46
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
2 times, most recently
from
84fd91e to
d12378d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3587 +/- ##
==========================================
+ Coverage 89.20% 91.00% +1.79%
==========================================
Files 155 156 +1
Lines 119229 135548 +16319
Branches 119229 135548 +16319
==========================================
+ Hits 106363 123358 +16995
+ Misses 10266 9715 -551
+ Partials 2600 2475 -125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
3 times, most recently
from
4c96307 to
e4ecb76
Compare
|
Draft for now as in dependency hell :( |
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
4 times, most recently
from
09e929a to
1d09868
Compare
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
4 times, most recently
from
094b538 to
db8c7c2
Compare
|
Blocked on rust-bitcoin/corepc#111 |
.. which is the newest version and also aligns with recent BDK releases.
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
from
f2b80af to
2cc608a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bump our
electrum_clientdependency to v0.22 which is the newest version and also aligns with recent BDK releases.Also, recently
rustlsintroduced a new default crypto provider inaws-lc-rc. Since there have been reports on this new provider not building properly on certain platformselectrum-clientintroducedadditional features allowing the user to configure what backend to use
for TLS.
Here, we simply re-expose these features to our users, which also mirrors what we do for Esplora already.