[Test] Add neg test for splice_channel with insufficient inputs #3674
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
optout21
force-pushed
the
splice-init-neg-test
branch
from
e44e0fb to
09520b4
Compare
|
Addressed review comments (jkczyz) |
|
🔔 1st Reminder Hey @wpaulino! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @wpaulino! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @wpaulino! This PR has been waiting for your review. |
optout21
force-pushed
the
splice-init-neg-test
branch
from
09520b4 to
a0fa32e
Compare
|
Incorporated minor suggestions from @shaavan . thx. Squashed into one commit, as changes were minimal. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3674 +/- ##
==========================================
- Coverage 89.26% 89.20% -0.06%
==========================================
Files 155 155
Lines 119911 119954 +43
Branches 119911 119954 +43
==========================================
- Hits 107038 107007 -31
- Misses 10262 10327 +65
- Partials 2611 2620 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In the
splice_channel()API the user has to provide the intended splice-in contribution, as well as the inputs that are used to cover that. In case the inputs are not enough (to cover the intended contribution plus proportional fees), an error is returned.This small PR adds a test for that.