-
Notifications
You must be signed in to change notification settings - Fork 427
Add log spans using thread local storage in std #4287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I've assigned @jkczyz as a reviewer! |
38d439b to
5d2f39f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4287 +/- ##
=======================================
Coverage 86.59% 86.60%
=======================================
Files 158 158
Lines 102408 102479 +71
Branches 102408 102479 +71
=======================================
+ Hits 88679 88748 +69
Misses 11310 11310
- Partials 2419 2421 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1355c20 to
c3714c6
Compare
14f583e to
aedfe0a
Compare
|
Rebased and fixed a The problem was that Fixed by making |
|
Taking this out of draft as I'm committed to adding span support, but putting it on hold while an alternative approach is being investigated: using proc-macros to transparently augment every method with an implicit logger parameter, which would allow passing the span stack through that invisible parameter instead of relying on TLS. |
This is a stripped-down version of #4223 where only the spans are stored in thread local storage. Contrary to storing the logger instance itself as well, this code change is fully optional and not interfering with the dev ux for no std users.
Example log output:
std-spans.log