Skip to content

Fix stable clippy string repeat lint#4727

Merged
joostjager merged 1 commit into
lightningdevkit:mainfrom
joostjager:fix-lint
Jun 24, 2026
Merged

Fix stable clippy string repeat lint#4727
joostjager merged 1 commit into
lightningdevkit:mainfrom
joostjager:fix-lint

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

Uncaught by broken CI

@ldk-reviews-bot

ldk-reviews-bot commented Jun 19, 2026

Copy link
Copy Markdown

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-claude-review-bot

ldk-claude-review-bot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

This is a re-review. I already analyzed this PR in a prior pass and found no issues. The change is trivial and behavior-preserving. No new changes to review.

No issues found.

@ldk-reviews-bot

Copy link
Copy Markdown

🔔 1st Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@valentinewallace

Copy link
Copy Markdown
Contributor

Care to re-push with no updates just so CI runs?

@ldk-reviews-bot

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Use str::repeat in DebugMsg tests to satisfy current stable clippy.
@joostjager

Copy link
Copy Markdown
Contributor Author

Re-pushed

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.90%. Comparing base (b6f3ad7) to head (999ab2d).
⚠️ Report is 3215 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4727      +/-   ##
==========================================
+ Coverage   84.54%   86.90%   +2.35%     
==========================================
  Files         137      161      +24     
  Lines       77617   111687   +34070     
  Branches    77617   111687   +34070     
==========================================
+ Hits        65625    97060   +31435     
- Misses       9949    12119    +2170     
- Partials     2043     2508     +465     
Flag Coverage Δ
fuzzing-fake-hashes 7.77% <ø> (?)
fuzzing-real-hashes 29.82% <ø> (?)
tests 86.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joostjager

Copy link
Copy Markdown
Contributor Author

Lint passes with CI enabled

@joostjager joostjager merged commit 6ac2cf3 into lightningdevkit:main Jun 24, 2026
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants