[sql-69] multi: improve kvdb migration progress logging#1301
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the observability of the KVDB to SQL migration process. By introducing structured progress logging and reporting total item counts for accounts, sessions, and firewall database entries, it allows operators to better monitor the status and completion of data migrations. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces progress logging for several SQL migration processes, including accounts, firewall database entries, privacy mapper rows, actions, and sessions. It establishes a consistent logging interval and updates migration functions to track and report the number of migrated items. A review comment suggests ensuring that the final log message for the privacy mapper migration accurately reflects the total number of rows migrated rather than the number of session groups.
7d9fa11 to
1eac12e
Compare
3182d8d to
0030412
Compare
Add clearer progress logging across the KVDB to SQL migration paths for accounts, sessions, and firewalldb. Log the total number of items to migrate where it is cheap to determine up front, and emit progress updates every 100 migrated items.
1eac12e to
2f5de80
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces progress logging for various KV to SQL migration processes, including accounts, firewall database entries, privacy mapper rows, actions, and sessions. By adding a constant interval for logging and tracking the migration count, the system now provides better visibility into long-running migration tasks. I have no feedback to provide as there were no review comments.
This PR adds clearer progress logging across the KVDB to SQL migration paths for
accounts,sessions, andfirewalldb.We try to log the total number of items to migrate for the different stores where it is cheap to determine up front, and emit progress updates every 100 migrated items.