Draft
Conversation
5f2682a to
2d1bccb
Compare
Pull Request Test Coverage Report for Build 10426710362Details
💛 - Coveralls |
2d1bccb to
8b579da
Compare
Contributor
Author
|
I think this is in a decent state for now - this change to I'd prefer to block merging this until that PR (or something similar enough) lands in a The gRPC message generators could be moved elsewhere, but I imagine moving them to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts to address #1078 .
I think this logic can probably be simplified a fair amount wrt. reducing the # of switches. I think adding wrapper types with their own validity-checking functions would also help for that; handling proto enums makes the test a lot larger, but I think most of the REST endpoints will have enum fields to support arguments as strings.
Rapid has some functions to autogenerate values via reflection: https://pkg.go.dev/pgregory.net/rapid#Make
I'm not sure if that will populate the gRPC private fields like
state,unknownFields, etc. IIUC we don't want those to be populated.This small test found some missing checks, which would probably get rejected later on. Will peek at other RPCs with more fields to test out more complex invariants.