[Part 4|*] Add unit tests for the previous introduced SQL Backend methods #10292
Conversation
ziggie1984
changed the base branch from
master
to
elle-payment-sql-series-new
ziggie1984
changed the title
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-4
branch
3 times, most recently
from
415144d to
439b619
Compare
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-4
branch
from
439b619 to
c922bc3
Compare
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-4
branch
7 times, most recently
from
3648e20 to
ae6c366
Compare
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds comprehensive unit tests for the newly introduced SQL backend for the payments database. The changes include refactoring existing tests to be database-agnostic, which is a great improvement for maintainability. The new SQL queries and the Go store implementation are well-structured and cover a wide range of functionalities. My main feedback is on adhering to the testing style guide in the new TestQueryPayments function, where t.Fatalf and t.Errorf should be replaced with assertions from the require library as mandated by the repository's style guide.
payments/db/payment_test.go
Outdated
| if err != nil { | ||
| t.Fatalf("unable to create test "+ | ||
| "payment: %v", err) | ||
| } |
There was a problem hiding this comment.
The project's style guide specifies that unit tests must use the require library for assertions.1 Please replace if err != nil { t.Fatalf(...) } with require.NoError(t, err, ...) for consistency and conciseness. This also applies to other t.Fatalf and t.Errorf calls in this test function, which should be replaced with appropriate require assertions (e.g., require.Equal, require.Len).
require.NoError(t, err, "unable to create test payment")Style Guide References
Footnotes
-
The style guide mandates the use of the
requirelibrary for assertions in unit tests to ensure consistency and readability. ↩
In this commit we add all queries which we will need to insert payment related data into the db.
In commit add the harness which will be used to run db agnostic tests against the kv and sql backend. However it does not use it in this commit but it will over the next commits enable these db agnostic tests for the relevant test functions.
Since now the sql backend is more strict in using the same session key we refactor the helper so that we can easily change the session key for every new attempt.
We make the QueryPayments test db agnostic and also keep a small test for querying the duplicate payments case in the kv world.
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-4
branch
from
ae6c366 to
b011ea6
Compare
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-4
branch
from
b011ea6 to
b515aaa
Compare
Now that every method of the interface was implemented we can remove the embedded reference to the KVStore.
We now test every test in the payment_test.go file against all databases.
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-4
branch
from
b515aaa to
bdbcc54
Compare
|
@ellemouton: review reminder |
2 participants
This PR adds the DB related unit tests for backend functions which were introduced in #10287 and #10291
and finalizes the implementation for the SQL backend.