graph/db: clean up test code in preparation for DB abtraction #9694
+99
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
guggero
approved these changes
Apr 9, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
nit: add t.Helper() since we're passing in t now?
There was a problem hiding this comment.
cool yea added 👍
bhandras
approved these changes
Apr 9, 2025
| } | ||
|
|
||
| func createTestVertex(db kvdb.Backend) (*models.LightningNode, error) { | ||
| func createTestVertex(t testing.TB) *models.LightningNode { |
| err = graph.forEachNode( | ||
| func(tx kvdb.RTx, n *models.LightningNode) error { | ||
| nodeMap[n.PubKeyBytes] = struct{}{} | ||
| err = graph.ForEachNode(func(tx NodeRTx) error { |
This commit cleans up the graph test code by removing unused kvdb type parameters from the `createTextVertex` and `createLightningNode` helper methods. We also pass in the testing parameter now so that we dont need to check the error each time we call `createTestVertex`.
Remove the kvdb.Backend parameter from the `createChannelEdge` helper. This is all in preparation for having the unit tests run against any DB backend.
Remove unused kvdb.Backend param from `randEdgePolicy` and `newEdgePolicy` test helpers.
Replace all tests calls to the private `forEachNode` method on the `KVStore` with the exported ForEachNode method. This is in preparation for having the tests run against an abstract DB backend.
ellemouton
force-pushed
the
graph-test-clean
branch
from
be0266e to
c5a4485
Compare
63 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some clean up in the
graph/dbtest code to start preparing the tests to be ready to run against an abstract DB (either kvdb or sql schema).Part of #9795