Skip to content

Refactor Payment PR 4 #9847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Refactor Payment PR 4 #9847

wants to merge 11 commits into from

Conversation

ziggie1984
Copy link
Collaborator

  • channeldb: rename PaymentControl struct
  • channeldb: unify payment related code
  • channeldb: rename pControl to paymentDB
  • channeldb: fix linter
  • lnd: introduce separate key-value payment db
  • multi: unify all payment related kv data
  • channeldb: add context to query method
  • multi: add new payments package
  • multi: fix linter
  • multi: add new payments package.
  • multi: move payment code from channeldb to payments lib.

ziggie1984 added 9 commits May 21, 2025 08:45
@ziggie1984
channeldb: rename PaymentControl struct
1d0af34 
In the following commits we will gradually unify the current
payment db operations into an interface to later down the road
support both backends (sql+kv).
@ziggie1984
channeldb: unify payment related code
2ba5b74 
We move all code from the payment_control.go into payments.go so
that for later commits we can easily have all payment db related
kv db code together.
@ziggie1984
channeldb: rename pControl to paymentDB
fa2298c
@ziggie1984
channeldb: fix linter
3a02bcd
@ziggie1984
lnd: introduce separate key-value payment db
13864ca 
We also addd this new db on the server level to use it in the
following commit to do all the payment related queries of the
rpcserver.
We add a new payment db instance on the server level. Which we
will you for the payment related queries in a following commit.
@ziggie1984
multi: unify all payment related kv data
6e866e2 
All interactions related to the payment db are now part of the
kvPaymentDB struct.
@ziggie1984
channeldb: add context to query method
7726333 
We add a context for the query method because the query method
will be part of the paymentDB interface and for the SQL case
we need the context for this method. So we add it here as well
although it is not used similar to the invoice design.
@ziggie1984
multi: add new payments package
09c0d03 
We add a new payments package and create a db interface for the
paymentDB there. This is already implemented for the KV db side
and will be implemented for the SQL side in future PRS.
@ziggie1984
multi: fix linter
a86b978
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 21, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ziggie1984 ziggie1984 force-pushed the refactor-payments-code-04 branch from 6c1b1f5 to 2538b0e Compare May 21, 2025 10:41
@ziggie1984 ziggie1984 force-pushed the refactor-payments-code-04 branch from 2538b0e to 2880b9a Compare May 21, 2025 10:56
@ziggie1984 ziggie1984 self-assigned this May 21, 2025
@ziggie1984 ziggie1984 added no-changelog payments Related to invoices/payments refactoring labels May 21, 2025
@ziggie1984 ziggie1984 force-pushed the refactor-payments-code-04 branch from 2880b9a to 7af0d56 Compare May 21, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ziggie1984 ziggie1984

Labels
no-changelog payments Related to invoices/payments refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ziggie1984