Revert "format tracebacks with cause (#100)" #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1c94520.
|
FYI @codeboten |
|
@dneuhaeuser-zalando it looks like the parameters for I haven't tested this yet, but searching through some python issues, it looks like in python2 the inverted arguments would have worked anyways: https://bugs.python.org/issue17413#msg184146 Either ways I'll take a look at adding some tests around this case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1c94520 introduced in PR #100
This fails with
AttributeError: 'str' object has no attribute '__cause__'in production for us. I'll look more deeply into why this happened later but for now this should fix the bleeding.