Calculate and set seconds and nanos for Span's Timestamp proto #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
approved these changes
Nov 7, 2018
|
Thanks @carlosalberto for approving. Are you able to give us an ETA on when this will be merged and a new release made? We are waiting on this fix being put in place before Skyscanner can start rolling out python Lightstep support in the company. |
|
Hey @michael-booth I think later today we should have it deployed to PyPi ;) |
|
Brilliant thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #56 this PR looks to provide better span timing resolution by providing the
secondsandnanos(fraction of the second) value for the Timestamp proto object.I wasn't sure about your contribution policy so I have not updated the VERSION file in the repo, looking at previous commits to master it appears you usually increment this separately in another commit. Happy to include that in this PR if required though.