Skip to content

Fix logging non-existent path #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix logging non-existent path #3595

merged 1 commit into from
Jun 20, 2025

Conversation

songponssw
Copy link
Contributor

@songponssw songponssw commented May 31, 2025 •
edited
Loading

Fix: #3444

@songponssw songponssw marked this pull request as ready for review June 18, 2025 17:03
@AkihiroSuda AkihiroSuda added this to the v1.1.2 milestone Jun 18, 2025
AkihiroSuda
AkihiroSuda reviewed Jun 19, 2025
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jun 19, 2025
View reviewed changes
jandubois
jandubois reviewed Jun 20, 2025
View reviewed changes
@AkihiroSuda
Copy link
Member

Please squash the commits

jandubois
jandubois requested changes Jun 20, 2025
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The mountWarnings variable is no longer needed. It is now always empty, so the loop at the bottom doesn't do anything.

  • The logrus.Warnf() call must be wrapped with if warn {}.

  • All commits need to be squashed.

  • The commit needs a DCO signature.

@songponssw @AkihiroSuda @jandubois
add warning log when non-existent directory
63c8912 
Signed-off-by: Songpon Srisawai <[email protected]>
Co-authored-by: Akihiro Suda <[email protected]>
Co-authored-by: Jan Dubois <[email protected]>
jandubois
jandubois approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

AkihiroSuda
AkihiroSuda approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 279c1aa into lima-vm:master Jun 20, 2025
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.

Log a warning if a mounted directory does not exist
3 participants
@songponssw @AkihiroSuda @jandubois