Resolve validation error #3634
Open
Resolve validation error #3634
+122
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
reviewed
Jun 17, 2025
pkg/limayaml/validate.go
Outdated
| } | ||
|
|
||
| func Validate(y *LimaYAML, warn bool) error { | ||
| errs := &ValidationErrors{} |
There was a problem hiding this comment.
Maybe it's better to use errors.Join?
Signed-off-by: Horiodino <[email protected]> updatec test-cases Signed-off-by: Horiodino <[email protected]> using err.join Signed-off-by: Horiodino <[email protected]>
Horiodino
force-pushed
the
resolve-validation-error
branch
from
e095c93 to
7c55bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the limayaml.Validate() function to collect and return all validation errors found in a Lima template, instead of stopping at the first encountered error.
Fixes: #3606
Updated the validation logic to accumulate multiple validation errors.