Add url and token params for kubernetes templates #4505
Merged
+114
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
force-pushed
the
kubernetes-join
branch
from
5c6f7dc to
14697a8
Compare
AkihiroSuda
reviewed
Jan 6, 2026
Allows joining an agent / worker to an existing cluster, instead of creating a control plane node and doing reset. Don't check for control plane config / images / processes, and don't output any message about the kubeconfig either. Signed-off-by: Anders F Björklund <[email protected]>
There was no error, but the Param was always empty map. Which made it impossible to customize the message text. Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
kubernetes-join
branch
2 times, most recently
from
42cc3b3 to
ac1bfb8
Compare
Member
Author
|
There should probably be some more "elegant" method, of propagating parameters from master to minions... Currrently you are required to run low-level commands on the node, and then copy them into a complex |
AkihiroSuda
reviewed
Jan 7, 2026
AkihiroSuda
reviewed
Jan 7, 2026
website/content/en/docs/examples/containers/kubernetes/_index.md
Outdated
Show resolved
Hide resolved
This reverts commit 93055a1. Signed-off-by: Anders F Björklund <[email protected]>
All commands are copied from the templates. This leads to some duplication, but so be it. Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
kubernetes-join
branch
from
ac1bfb8 to
6ad4fd4
Compare
AkihiroSuda
reviewed
Jan 8, 2026
| ```bash | ||
| limactl start --name k3s-0 --network lima:user-v2 template:k3s | ||
| printf "https://lima-%s.internal:6443\n" k3s-0 | ||
| # (The url for the start command printed here) |
Member
There was a problem hiding this comment.
This printf does not seem needed?
Just set .param.url to https://lima-k3s-0.internal:6443 ?
Member
Author
There was a problem hiding this comment.
It is only needed when you change k3s-0, like in the test - but it was a workaround for the missing address
i.e. the k3s node creation doesn't record the endpoint IP anywhere, so I resorted to constructing it myself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows joining an agent / worker to an existing cluster,
instead of creating a control plane node and doing reset.
Don't check for control plane config / images / processes,
and don't output any message about the kubeconfig either.
Fixes #4481