Better support for "osu! subdivide nations" extension#80
Open
donMerloni wants to merge 1 commit intolimjeck:masterfrom
Open
Better support for "osu! subdivide nations" extension#80donMerloni wants to merge 1 commit intolimjeck:masterfrom
donMerloni wants to merge 1 commit intolimjeck:masterfrom
Conversation
The "osu! subdivide nations" extension adds its region flags as an anchor <a> element, which is something the old css selector does not account for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using the osu! subdivide nations extension, osuplus can't get the user ID for players with the extra flag because it happens to sit in an anchor
<a>element at index 1.so at the end the
playerInfoarray is shorter than expected and we crash at the first null element member access:(I trimmed off some rows at the top)
using
.ranking-page-table__user-link-textseems better (and probably more robust in general)