Allow to support end-to-end SDP#10
Open
ajutras-linaro wants to merge 1 commit into
Open
Conversation
Add the support for providing the sub-sample data to the CDMi service. Maintain the support for non-SDP and for SDP prototype. Define some macros (OCDM_SDP_*) to customize the implementation for non-SDP, SDP prototype and end-to-end SDP. Signed-off-by: Alexandre Jutras <alexandre.jutras@linaro.org>
ajutras-linaro
requested review from
andrey-konovalov,
petegriffin and
psivasubramanian
petegriffin
approved these changes
Jan 10, 2019
|
|
||
|
|
||
| /* OpenCDM Secure Data Path configuration */ | ||
| /* SDP disabled: OpenCDM do not use SDP. When OCDM_SDP is not defined, SDP |
There was a problem hiding this comment.
Thanks for the good documentation of the various configurations! We may also need to copy some of this into the OE recipe that sets the flags.
| void SelectSession(const std::string& ); | ||
| bool IsTypeSupported(const std::string& keySystem,const std::string& mimeType); | ||
| int Decrypt(unsigned char*, uint32_t, unsigned char*, uint32_t); | ||
| int Decrypt(unsigned char*, uint32_t, unsigned char*, uint32_t, uint32_t *, uint32_t, int, uint32_t); |
There was a problem hiding this comment.
@ajutras-linaro Are we changing WPE gstreamer decryptor code as well?
Author
There was a problem hiding this comment.
Yes, you can see the proposed changes at: ajutras-linaro/WebKitForWayland#1. Thinking about it, there are better options to handle the change in API (example: function overloading). I will implement a better solution for the next patch set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the support for providing the sub-sample data to the CDMi service.
Maintain the support for non-SDP and for SDP prototype. Define some
macros (OCDM_SDP_*) to customize the implementation for non-SDP,
SDP prototype and end-to-end SDP.