Skip to content

Comments

LR Scheduler implemented#652

Merged
SamSandwich07 merged 13 commits intomainfrom
issue/135-lr-scheduler
Feb 10, 2026
Merged

LR Scheduler implemented#652
SamSandwich07 merged 13 commits intomainfrom
issue/135-lr-scheduler

Conversation

@SamSandwich07
Copy link
Collaborator

Allows users to configure a single basic (i.e. not Chained or Sequential) learning rate scheduler in the config. Closes #135.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.25%. Comparing base (0dabbe8) to head (928796a).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/hyrax/models/model_registry.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   62.96%   63.25%   +0.28%     
==========================================
  Files          59       59              
  Lines        5730     5769      +39     
==========================================
+ Hits         3608     3649      +41     
+ Misses       2122     2120       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Before [0dabbe8] After [6cee331] Ratio Benchmark (Parameter)
36.4±0.2ms 38.4±0.2ms 1.06 benchmarks.time_nb_obj_construct
37.8±0.6ms 39.8±0.5ms 1.05 benchmarks.time_nb_obj_dir
9.72±0.04s 10.0±0.1s 1.03 vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(16384, 'chromadb')
9.50±0.3ms 9.82±0.2ms 1.03 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(128, 'chromadb')
475±2ms 490±1ms 1.03 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(128, 'qdrant')
1.99±0.05s 2.03±0.06s 1.02 benchmarks.time_prepare_help
38.9±0.05s 39.1±0.2s 1.01 vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(16384, 'qdrant')
481±2ms 485±2ms 1.01 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(64, 'qdrant')
1.96±0.03s 1.96±0.05s 1 benchmarks.time_lookup_help
7.52±0.02s 7.50±0.01s 1 data_cache_benchmarks.DataCacheBenchmarks.time_preload_cache_hsc1k

Click here to view all benchmarks.

@SamSandwich07 SamSandwich07 marked this pull request as draft January 29, 2026 22:27
@SamSandwich07 SamSandwich07 marked this pull request as ready for review February 2, 2026 23:41
@drewoldag
Copy link
Collaborator

@SamSandwich07 looks like the unit tests aren't passing. I'll take a quick look over the PR anyway, since I doubt that there failing unit test will require substantial rework.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far this is looking good. Left a couple of comments.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looks good to me. Thanks for putting this together!

@SamSandwich07 SamSandwich07 merged commit 68c8e0c into main Feb 10, 2026
9 checks passed
@SamSandwich07 SamSandwich07 deleted the issue/135-lr-scheduler branch February 10, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement configurable learning rate scheduler

2 participants