Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
+ Coverage 62.96% 63.25% +0.28%
==========================================
Files 59 59
Lines 5730 5769 +39
==========================================
+ Hits 3608 3649 +41
+ Misses 2122 2120 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
Collaborator
|
@SamSandwich07 looks like the unit tests aren't passing. I'll take a quick look over the PR anyway, since I doubt that there failing unit test will require substantial rework. |
drewoldag
reviewed
Feb 4, 2026
Collaborator
drewoldag
left a comment
There was a problem hiding this comment.
So far this is looking good. Left a couple of comments.
Co-authored-by: Drew Oldag <47493171+drewoldag@users.noreply.github.com>
drewoldag
approved these changes
Feb 9, 2026
Collaborator
drewoldag
left a comment
There was a problem hiding this comment.
This is looks good to me. Thanks for putting this together!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to configure a single basic (i.e. not Chained or Sequential) learning rate scheduler in the config. Closes #135.