Skip to content

Add FollowDetail type for FollowEvent #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nottyo
Copy link

@nottyo nottyo commented Apr 25, 2025

To add FollowDetail object type to the FollowEvent type

Ref: https://developers.line.biz/en/reference/messaging-api/#follow-event

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2025

CLA assistant check
All committers have signed the CLA.

@Yang-33
Copy link
Contributor

Yang-33 commented Apr 28, 2025

how about using

?

@nottyo
Copy link
Author

nottyo commented Apr 28, 2025

Yeah, it's usable but the type defined in the lib/types still not up to date. Mostly people reference the type definition from this file, so should we update it as well ?

I mean we usually import the type like this

import { FollowEvent } from '@line/bot-sdk';

which is not up to date yet.

rather than

import { FollowEvent } from '@line/bot-sdk/dist/webhook/api';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants