Preserve (don't clamp) negative half-leading - #743
Open
nicoburns wants to merge 1 commit into
Open
Conversation
Line box extents now default to f32::NEG_INFINITY instead of 0 so that content whose over/under extents are legitimately negative (e.g. text with line-height smaller than ascent + descent) is not floored at zero. The sentinel is resolved to zero when a line has no contributing content, so it never escapes into public metrics. Out-of-flow inline boxes now contribute negative-infinity extents (a no-op under max) rather than zero, so they no longer floor the line's extents either.
nicoburns
changed the title
DJMcNab
reviewed
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
line-height < ascent + descent, half-leading is legitimately negative:f32::NEG_INFINITYso legitimately negative extents are preserved.LLM Contributions
Code generated with Devin Ultra.
Changelog Entry