Skip to content

Add fact about Japanese addresses#12049

Open
zulkiflidev wants to merge 1 commit intolingdojo:mainfrom
zulkiflidev:zulkiflidev-patch-5
Open

Add fact about Japanese addresses#12049
zulkiflidev wants to merge 1 commit intolingdojo:mainfrom
zulkiflidev:zulkiflidev-patch-5

Conversation

@zulkiflidev
Copy link
Copy Markdown
Contributor

📝 Description

...

🔗 Related Issue

Closes #12048

🎯 Type of Change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Documentation update (e.g., this file, README)
  • content: Content update (e.g., new kanji, vocab, or fonts in /static/)
  • style: UI/Theme changes (e.g., Tailwind, CSS, new themes)
  • refactor: Code refactor (no functional changes)
  • test: Test update (adding missing tests or correcting existing tests)
  • chore: Build, CI/CD, or dependency updates

🧪 How Has This Been Tested?

Test Steps:

  1. ...
  2. ...

Manual Test Checklist:

  • Tested in Kana dojo
  • Tested in Kanji dojo
  • Tested in Vocabulary dojo
  • Tested all 4 game modes (Pick, Reverse-Pick, Input, Reverse-Input)
  • ... (add any other specific tests)

📸 Screenshots/Videos (if applicable)

...

✅ Pre-Submission Checklist

  • My code follows the project's code style and uses cn() utility where needed.
  • I have run npm run check locally and there are no TypeScript/ESLint errors.
  • My commit messages follow the Conventional Commits format.
  • I have updated the documentation (if applicable).
  • This PR is against the main branch.

Helpful links: Contributing · Troubleshooting

📦 Additional Context

...

Signed-off-by: Zulkifli <44313543+zulkiflidev@users.noreply.github.com>
@tentoumushii
Copy link
Copy Markdown
Collaborator

🎉 Thanks for your Pull Request, @zulkiflidev!

We appreciate your contribution to KanaDojo!

Pre-merge checklist:

  • You starred our repo ⭐
  • Code follows project style guidelines
  • Changes have been tested locally
  • PR title is descriptive
  • If this closes an issue, it's linked with Closes #<number>

A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run npm run check locally to match CI.

ありがとうございます! 🙏

@tentoumushii
Copy link
Copy Markdown
Collaborator

🤖 Auto-Review: ✅ Passed

This fact contribution has passed automated validation!

Checks passed:

  • ✅ Changed files are in the allowed location
  • ✅ Changed JSON files parse successfully
  • ✅ Related issue found

📎 Linked issue: #12048

Once the quality check passes, this PR will be automatically approved for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] 🎴 Add new Japan Fact 27 - Beginner-Friendly Open-source Contribution

2 participants