httpserver: return an error for unknown notifier class in config detail - #868
Open
ZayanKhan-12 wants to merge 1 commit into
Open
httpserver: return an error for unknown notifier class in config detail#868ZayanKhan-12 wants to merge 1 commit into
ZayanKhan-12 wants to merge 1 commit into
Conversation
configNotifierDetail's class-name switch had no default case, so a
notifier module with an unhandled class-name returned an empty body
with a 200 status code from /v3/config/notifier/{name}. Return a 500
error response instead, and cover it with a test.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
configNotifierDetail'sclass-nameswitch has nodefaultcase. For a notifier whoseclass-nameis nothttp/email/slack/null,/v3/config/notifier/{name}writes no response at all — the client receives an empty body with a200status code, which reads as a successful-but-broken response.Fix
Add a
defaultcase that returns a500error response (unknown notifier class), matching the error-response style used elsewhere in the file.Testing
Added
TestHttpServer_configNotifierDetail_UnknownClasscovering the new path (asserts 500 + error body).go test -race ./...passes.🤖 Generated with Claude Code