Skip to content

Keeping Trigger Timestamp in Job Annotation Updated - #172

Merged
srnand merged 1 commit into
mainfrom
sthakkar/nov5/keepingJobAnnotationsUpToDate
Nov 6, 2025
Merged

Keeping Trigger Timestamp in Job Annotation Updated#172
srnand merged 1 commit into
mainfrom
sthakkar/nov5/keepingJobAnnotationsUpToDate

Conversation

@srnand

@srnand srnand commented Nov 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Problem

  • The trigger timestamp is annotated in the job's metadata when the job is created but any extended implementations of the TableTrigger Reconciler can update the trigger timestamp on the tableTrigger object, hence this change ensures that annotations remain up to date while the job is in progress.

Test

  • Added UT.

@srnand
srnand force-pushed the sthakkar/nov5/keepingJobAnnotationsUpToDate branch from 2597463 to c9c3000 Compare November 6, 2025 00:36
ryannedolan
ryannedolan approved these changes Nov 6, 2025
View reviewed changes

@ryannedolan ryannedolan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@srnand
srnand merged commit 1e5cf86 into main Nov 6, 2025
1 check passed
@srnand
srnand deleted the sthakkar/nov5/keepingJobAnnotationsUpToDate branch November 6, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryannedolan ryannedolan ryannedolan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srnand @ryannedolan @shrinandthakkar