Support URL encoded hints - #173
Merged
Merged
Conversation
jogrogan
force-pushed
the
jogrogan/hintsEncoding
branch
from
November 7, 2025 16:39
4420f78 to
69df71d
Compare
ryannedolan
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parsing logic for hints was always kind of flaky. There was an implicit requirement that hints couldn't have commas, semicolons, equals signs, and other special characters. The solution for this is to also support URL encoded strings, this jibes well with JDBC and allows parsing of more complex hint values, like string encoded arrays.