[WAGED Tag Isolation 4/16] Add the bookkeeping class - #284
Draft
LZD-PratyushBhatt wants to merge 1 commit into
Draft
LZD-PratyushBhatt wants to merge 1 commit into
LZD-PratyushBhatt wants to merge 1 commit into
Conversation
Introduce InstanceTagIsolation, the object that will let WAGED tolerate one unplaceable instance group instead of aborting the whole pass. This change only adds the bookkeeping half: the isolation group key of a replica, the record of what this run has placed per group, the set of groups seen and groups failed, and the throwaway failure sink that keeps a tolerated failure from marking the returned assignment as failed. Every method returns immediately when the feature is disabled, so wiring it up later cannot change the default behavior. Nothing constructs the class yet. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LZD-PratyushBhatt
added this pull request to stack #297
September 20, 2026 05:46
LZD-PratyushBhatt
changed the title
LZD-PratyushBhatt
added
the
waged-tag-level-isolation
LZD-PratyushBhatt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce InstanceTagIsolation, the object that will let WAGED tolerate one
unplaceable instance group instead of aborting the whole pass.
This is the bookkeeping half only: the isolation group key of a replica,
the record of what the run has placed per group, the sets of groups seen
and failed, and the throwaway failure sink that keeps a tolerated failure
from marking the returned assignment as failed.
Every method returns immediately when the feature is disabled. Nothing
constructs the class yet.
Stacked PR 4 of 16 for WAGED instance tag isolation.
Base branch:
lzd/waged-iso-03-collision. Only the top commit belongs to this PR.The whole stack merges into
waged-tag-based-isolation, which is merged intodevat the end.Tests
No behavior to test yet: nothing constructs the class. The tests arrive
with the PRs that make it reachable.
Changes that Break Backward Compatibility
None. The new cluster config flag defaults to false, and with it off every
code path added here behaves exactly as it does today.
Documentation
The design doc lands in
lzd/waged-iso-13-docasdocs/design/002-waged-instance-tag-isolation.md.Code Quality
Formatted with helix-style.xml.