[WAGED Tag Isolation 7/16] Hook into the assignment loop - #287
Draft
LZD-PratyushBhatt wants to merge 1 commit into
Draft
LZD-PratyushBhatt wants to merge 1 commit into
LZD-PratyushBhatt wants to merge 1 commit into
Conversation
Turn the bookkeeping added so far into working behavior. The assignment loop now skips replicas whose group has already failed, records each placement so it can be released, routes hard constraint failures through a sink that a tolerated failure will not mark as failed, and asks the isolation object to absorb a placement failure before rethrowing it. At the end of the pass, finish either rethrows or reports the skipped resources. Also lifts the scoring capacity loop into its own method, which is a pure move. All of this is inert unless WAGED_INSTANCE_TAG_ISOLATION_ENABLED is set on the cluster config: with the flag off, the isolation object answers no to every question and the loop behaves exactly as before. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LZD-PratyushBhatt
added this pull request to stack #297
September 20, 2026 05:46
LZD-PratyushBhatt
changed the title
LZD-PratyushBhatt
added
the
waged-tag-level-isolation
LZD-PratyushBhatt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Turn the bookkeeping added so far into working behavior. This is the PR
where the feature becomes reachable.
The assignment loop now skips replicas whose group already failed, records
each placement so it can be released, routes hard constraint failures
through a sink a tolerated failure will not mark as failed, and asks the
isolation object to absorb a placement failure before rethrowing. Also
lifts the scoring capacity loop into its own method, which is a pure move.
Inert unless WAGED_INSTANCE_TAG_ISOLATION_ENABLED is set: with the flag
off the isolation object answers no to every question and the loop behaves
exactly as before.
Stacked PR 7 of 16 for WAGED instance tag isolation.
Base branch:
lzd/waged-iso-06-isolate. Only the top commit belongs to this PR.The whole stack merges into
waged-tag-based-isolation, which is merged intodevat the end.Tests
Existing WAGED suites, to prove flag-off parity.
Changes that Break Backward Compatibility
None. The new cluster config flag defaults to false, and with it off every
code path added here behaves exactly as it does today.
Documentation
The design doc lands in
lzd/waged-iso-13-docasdocs/design/002-waged-instance-tag-isolation.md.Code Quality
Formatted with helix-style.xml.