Correct Python <= 3.7 compatibility regression in commit 377c70d#256
Open
nkaminski wants to merge 2 commits intolinkedin:mainfrom
Open
Correct Python <= 3.7 compatibility regression in commit 377c70d#256nkaminski wants to merge 2 commits intolinkedin:mainfrom
nkaminski wants to merge 2 commits intolinkedin:mainfrom
Conversation
…ility regression in commit 377c70d This change enables support in Python 3.7 for deferred type evaluation as well as increases the minimum Python version to 3.7.
|
#255 indicates that compatibility with Python 3.8 was broken as well, presumably due to this issue which manifests in Pythons < 3.9. Don't quote me on that, though. I only looked at it long enough to determine that 1.0.7 broke Python 3.8, and pinned my requirements to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change drops Python 3.6 support as well as enables Python 3.7 support for deferred type evaluation, as this is the minimum version Python version required to support the usage of type annotations requiring deferred evaluation that were introduced in commit 377c70d .
As of the present PyPi release 1.0.7, the following type hinting error occurs under Python 3.6 as well as 3.7:
This can be further illustrated on Compiler Explorer at: https://godbolt.org/z/1eWcT4jsW