ci: removed standard-version config in package.json #2098
+58
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-zimnowoda
reviewed
Apr 28, 2025
Contributor
j-zimnowoda
left a comment
j-zimnowoda
left a comment
There was a problem hiding this comment.
What about the regular release pipeline. I am pretty sure that it relies on that setting?
Coverage report
Test suite run success143 tests passing in 13 suites. Report generated by 🧪jest coverage report action from d8c8c6e |
j-zimnowoda
reviewed
Apr 30, 2025
| "bootstrap-dev-with-repo": "CI=1 ENV_DIR=/tmp/otomi-bootstrap-dev binzx/otomi bootstrap", | ||
| "bootstrap-tests-fixtures": "CI=1 ENV_DIR=$PWD/tests/fixtures binzx/otomi bootstrap" | ||
| }, | ||
| "standard-version": { |
Contributor
There was a problem hiding this comment.
Please double check with Create and push git tag task. In particular how changing this config impacts the following statement:
git tag -am "$COMMIT_MSG" $release_tag && git push --follow-tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
While trying to generate our first release candidate, the pipeline failed because of a missing tag which should have been created by running the release command.
Apparently this behavior was disabled in packages.json.
🔍 Reviewer Notes
🧹 Checklist