Skip to content

Conversation

@pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Nov 19, 2025

Description 📝

  • Make the Ruleset label in the Firewall Rules table clickable. Clicking it should open a Ruleset details drawer showing its associated information, including the list of Prefixlists (if available or referenced) [NOTE: Prefix Lists are not implemented in this PR].
  • When a ruleset deletion is initiated at the system level from the backend, the corresponding ruleset row in the Firewall Rules table should be marked as "⚠️ Marked for deletion" until all references of that ruleset to the firewall are removed. The Rule Set will be automatically removed once all of its references are deleted.

Changes 🔄

  • Added a new Rule Set Details drawer.
  • When a Rule Set is deleted but still has references to the firewall, opening the Rule Set drawer will display a ⚠️ Marked for deletion status.
  • Add some unit tests

Scope 🚢

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

N/A

Preview 📷

Description Preview
Rule Set Details Drawer (eg., Mocked firewall-ruleset-1) Screenshot 2025-11-20 at 11 22 42 PM
Rule Set Details Drawer with Marked for Deletion status & Tooltip message (eg., Mocked ruleset-with-a-longer-32ch-label) Screenshot 2025-11-20 at 11 32 22 PM Screenshot 2025-11-20 at 11 42 37 PM

How to test 🧪

Prerequisites

  • Enable firewallRulesetsPrefixlists feature flag
  • Enable MSW (with Legacy MSW Handlers)

Verification steps

  • Navigate to the Firewalls Landing page and locate the "firewall with rule and ruleset reference" instance. Go to its details page
  • Refer to the preview screenshots above and verify the Ruleset Details page by clicking the ruleset label for both a normal ruleset and a ruleset marked with "⚠️ Marked for deletion" status
  • Ensure there are no regressions
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

…layout' into UIE-9514-update-firewall-rule-drawer-to-support-referencing-ruleset
@pmakode-akamai pmakode-akamai marked this pull request as ready for review November 21, 2025 17:34
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner November 21, 2025 17:34
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #21 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing859 Passing11 Skipped48m 38s

Details

Failing Tests
SpecTest
vpc-details-page.spec.tsCloud Manager Cypress Tests→VPC details page » can create, edit, and delete a subnet from the VPC details page
firewall-landing-page.spec.tsCloud Manager Cypress Tests→confirms Firewalls landing page empty state is shown when no Firewalls exist » lists all Firewalls
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/vpc/vpc-details-page.spec.ts,cypress/e2e/core/firewalls/firewall-landing-page.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Firewalls Related to Firewalls Ready for Review

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

2 participants