libnvme-wrap: drop unused code#3547
Merged
Merged
Conversation
libnvme-wrap was intended to allow nvme-cli to run against older libnvme versions. In practice, this never worked particularly well. With libnvme now integrated into nvme-cli and the library API cleaned up, drop this compatibility layer. Distributions are better suited to handle library dependencies, and users building their own versions will receive proper linker errors instead of relying on compatibility code that only worked partially. Signed-off-by: Daniel Wagner <wagi@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnvme-wrap was intended to allow nvme-cli to run against older libnvme versions. In practice, this never worked particularly well. With libnvme now integrated into nvme-cli and the library API cleaned up, drop this compatibility layer.
Distributions are better suited to handle library dependencies, and users building their own versions will receive proper linker errors instead of relying on compatibility code that only worked partially.